Skip to content

fix(tests/unit): fix MinGW build in serializeProtoUnitTest#3161

Merged
IvanNardi merged 1 commit into
ntop:devfrom
fabiodepin:bug-unit-win32
Apr 16, 2026
Merged

fix(tests/unit): fix MinGW build in serializeProtoUnitTest#3161
IvanNardi merged 1 commit into
ntop:devfrom
fabiodepin:bug-unit-win32

Conversation

@fabiodepin

Copy link
Copy Markdown
Contributor

The closing brace for the CSV format branch was inside #ifndef WIN32, so the preprocessor removed it on Windows and broke the brace structure, causing bogus errors around main() with -Werror.

Please sign (check) the below before submitting the Pull Request:

Link to the related 3160:

Describe changes:

fix(tests/unit): fix MinGW build in serializeProtoUnitTest

The closing brace for the CSV format branch was inside #ifndef WIN32, so
the preprocessor removed it on Windows and broke the brace structure,
causing bogus errors around main() with -Werror.

The closing brace for the CSV format branch was inside #ifndef WIN32, so
the preprocessor removed it on Windows and broke the brace structure,
causing bogus errors around main() with -Werror.
@sonarqubecloud

Copy link
Copy Markdown

@IvanNardi IvanNardi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@IvanNardi IvanNardi merged commit 68c7159 into ntop:dev Apr 16, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants